Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conda installation functions private #2

Open
allemangD opened this issue Mar 4, 2024 · 0 comments
Open

Make conda installation functions private #2

allemangD opened this issue Mar 4, 2024 · 0 comments

Comments

@allemangD
Copy link

One of the nitpick issues mentioned in Slicer/ExtensionsIndex#2006 (review)

Make the conda installation functions installConda into __private methods so it is clear they shall not be called by third-party code.

The only way to install anything to system should be via the CondaSetUp module UI, or by manually installing a distribution and setting its path. Making these methods private will ensure, or at least make obvious, that other modules shall not automatically install conda distributions without user input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant