add null-safety; update readme

D00mch · Aug 28, 2018 · f96a5b9 · f96a5b9
1 parent ccce43d
commit f96a5b9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@ This lib is inspired by Hannes Dorfmann [AdapterDelegates](https://github.com/so
 
 for java:
 ```groovy
-compile 'com.github.liverm0r:delegateadapters:v1.11'
+implementation 'com.github.liverm0r:delegateadapters:v1.11'
 ```
 
 for kotlin:
@@ -19,7 +19,7 @@ android {
         experimental = true
     }
 }
-compile 'com.github.liverm0r:delegateadapters:v2.0'
+implementation 'com.github.liverm0r:delegateadapters:v2.0'
 ```
 
 You also have to add this in your project build.gradle

diff --git a/delegateadapter/src/main/java/com/example/delegateadapter/delegate/BaseDelegateAdapter.java b/delegateadapter/src/main/java/com/example/delegateadapter/delegate/BaseDelegateAdapter.java
@@ -28,7 +28,7 @@ abstract protected void onBindViewHolder(@NonNull View view,
     abstract protected VH createViewHolder(View parent);
 
     @Override
-    public void onRecycled(VH holder) {
+    public void onRecycled(@NonNull VH holder) {
     }
 
     @NonNull

diff --git a/...eadapter/src/main/java/com/example/delegateadapter/delegate/CompositeDelegateAdapter.java b/...eadapter/src/main/java/com/example/delegateadapter/delegate/CompositeDelegateAdapter.java
@@ -52,7 +52,7 @@ public final void onBindViewHolder(RecyclerView.ViewHolder holder, int position)
     }
 
     @Override
-    public void onViewRecycled(RecyclerView.ViewHolder holder) {
+    public void onViewRecycled(@NonNull RecyclerView.ViewHolder holder) {
         //noinspection unchecked
         typeToAdapterMap.get(holder.getItemViewType()).onRecycled(holder);
     }

diff --git a/delegateadapter/src/main/java/com/example/delegateadapter/delegate/IDelegateAdapter.java b/delegateadapter/src/main/java/com/example/delegateadapter/delegate/IDelegateAdapter.java
@@ -18,7 +18,7 @@ void onBindViewHolder(@NonNull VH holder,
                           @NonNull List<T> items,
                           int position);
 
-    void onRecycled(VH holder);
+    void onRecycled(@NonNull VH holder);
 
     boolean isForViewType(@NonNull List<?> items, int position);
 }