Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON schema is not consistent with the golang structure #196

Open
shlomitk1 opened this issue Sep 25, 2024 · 0 comments · May be fixed by #197
Open

JSON schema is not consistent with the golang structure #196

shlomitk1 opened this issue Sep 25, 2024 · 0 comments · May be fixed by #197
Labels
bug Something isn't working good first issue Good for newcomers spec/1.6

Comments

@shlomitk1
Copy link

According to

cyclonedx-go/cyclonedx.go

Line 253 in 98a070d

Data *ComponentData `json:"data,omitempty" xml:"data,omitempty"`

Data is a pointer to ComponentData, whereas the schema defines Data as an array of ComponentData:

cyclonedx-go/schema/bom-1.6.schema.json

Lines 1075 to 1080 in 98a070d

"data": {
"type": "array",
"items": {"$ref": "#/definitions/componentData"},
"title": "Data",
"description": "This object SHOULD be specified for any component of type `data` and MUST NOT be specified for other component types."
},

@nscuro nscuro added bug Something isn't working good first issue Good for newcomers spec/1.6 labels Sep 25, 2024
@jameskim0987 jameskim0987 linked a pull request Sep 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers spec/1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE-196] Fix JSON schema inconsistency jameskim0987/cyclonedx-go
2 participants
@nscuro @shlomitk1