Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader shows up in some parts of the application when ajax request completes #72

Open
Creatoon opened this issue Aug 20, 2021 · 10 comments · May be fixed by #74
Open

Loader shows up in some parts of the application when ajax request completes #72

Creatoon opened this issue Aug 20, 2021 · 10 comments · May be fixed by #74
Labels
fix if you have fixed an bug , add this to your commits good first issue This issue is good for first timers

Comments

@Creatoon
Copy link
Owner

Describe the bug
In many parts of the application where an ajax request is being made, there is a loader to show like your request is being processed, now there is no error handling for the request failure case -> Request gets failed but the loader is still showing up.

To Reproduce

  1. Go to http://52.66.208.178:9876/me
  2. Click on the upload photo button
  3. see error and loader

Expected behaviour
The loader should have stopped after the error comes.

Screenshots

Screenshot from 2021-08-20 18-10-24

Screenshot from 2021-08-20 18-10-28

@Creatoon Creatoon added good first issue This issue is good for first timers fix if you have fixed an bug , add this to your commits labels Aug 20, 2021
@AbhijithGanesh
Copy link

I am unable to replicate the issue, what should I do?

@Creatoon
Copy link
Owner Author

Creatoon commented Sep 4, 2021

@AbhijithGanesh what errors you are getting ?

@AbhijithGanesh
Copy link

I am not getting the loader itself

@AbhijithGanesh
Copy link

image
Loader isn't there at all

@Creatoon
Copy link
Owner Author

Creatoon commented Sep 7, 2021

Click on change photo button -> select photo -> click on update button, you will see a loader on the update button itself

@AbhijithGanesh
Copy link

Understood the Issue, working on it.

@AbhijithGanesh
Copy link

The asynchronous error is related to AWS which I am not familiar with, It says specific bucket is not valid, it is related to the API which axios sends I suppose. Can you please help?

@Creatoon
Copy link
Owner Author

Creatoon commented Sep 7, 2021

You don't have care about aws, you just have find its error handling.
Which will be like this
Catch(err){}
In this you have remove the loader just

@AbhijithGanesh
Copy link

I did that yet it shows the specified bucket is not valid error? I will make a PR soon

@Creatoon
Copy link
Owner Author

Creatoon commented Sep 7, 2021

Make the pr, I will review it

@AbhijithGanesh AbhijithGanesh linked a pull request Sep 7, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix if you have fixed an bug , add this to your commits good first issue This issue is good for first timers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants