-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adde Home Page #41
base: development
Are you sure you want to change the base?
Adde Home Page #41
Conversation
Added Home Page
Added Button hover Effect and Home page template style
Added route to home.js
@@ -148,8 +153,9 @@ a { | |||
.btn { | |||
text-decoration: none; | |||
margin-right: 2.2rem; | |||
color: #7158e2; | |||
color: white; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ?
.btn:after{ | ||
border-radius: 30px; | ||
/* color: var(--skin-color) */ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused css code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for the effects after hovering the button
@@ -39,6 +39,7 @@ router.get( | |||
viewController.getCreateRoomPage | |||
); | |||
|
|||
router.get('/home', viewController.getHomePage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the issue properly, I said, add a home or landing page on "/" URI, not on "/home" URI
@0xCipher-max I really appreciate your enthusiasm, but you can see the page as well. |
Yes, I was showing you only the template. I will add details and other things to it as well. Please give me the details to add in the "about" and "contact" section |
I will modify it accordingly. |
I've tried to make the header and footer of the same color so that they can be differentiated from the content box. |
@0xCipher-max I am not saying about the color, look at the border radius , make it like top (header ) one |
@0xCipher-max you should have handle this issue on a separate branch, remember from next time. |
@0xCipher-max send your email, will be having a meet with you |
Yaa sure!! |
Fixes #32
Short description of what this resolves:
I've added a homepage for this web-app
Changes proposed in this pull request:
Checklist
development
branch.