Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adde Home Page #41

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

0xCipher-max
Copy link

Fixes #32

Short description of what this resolves:

I've added a homepage for this web-app

Changes proposed in this pull request:

  • Updated viewController.js
  • Updated style.css
  • Updated viewRoute.js
  • added home.pug

Checklist

  • My branch is up-to-date with the Upstream development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Added Home Page
Added Button hover Effect and Home page template style
Added route to home.js
@@ -148,8 +153,9 @@ a {
.btn {
text-decoration: none;
margin-right: 2.2rem;
color: #7158e2;
color: white;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

.btn:after{
border-radius: 30px;
/* color: var(--skin-color) */
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused css code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for the effects after hovering the button

@@ -39,6 +39,7 @@ router.get(
viewController.getCreateRoomPage
);

router.get('/home', viewController.getHomePage);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the issue properly, I said, add a home or landing page on "/" URI, not on "/home" URI

@Creatoon
Copy link
Owner

Although the page looks too much empty, you can add our company description, add an illustration to make the page attractive, also see the footer it is not matching with the above container. Also no need of adding about-us, contact-us buttons on the top, they should be on the footer.

Screenshot from 2021-06-17 15-24-06

@Creatoon
Copy link
Owner

@0xCipher-max I really appreciate your enthusiasm, but you can see the page as well.

@0xCipher-max
Copy link
Author

Although the page looks too much empty, you can add our company description, add an illustration to make the page attractive, also see the footer it is not matching with the above container. Also no need of adding about-us, contact-us buttons on the top, they should be on the footer.

Screenshot from 2021-06-17 15-24-06

Yes, I was showing you only the template. I will add details and other things to it as well. Please give me the details to add in the "about" and "contact" section

@0xCipher-max
Copy link
Author

@0xCipher-max I really appreciate your enthusiasm, but you can see the page as well.

I will modify it accordingly.

@0xCipher-max
Copy link
Author

Although the page looks too much empty, you can add our company description, add an illustration to make the page attractive, also see the footer it is not matching with the above container. Also no need of adding about-us, contact-us buttons on the top, they should be on the footer.

Screenshot from 2021-06-17 15-24-06

I've tried to make the header and footer of the same color so that they can be differentiated from the content box.
I can change footer color if you want

@Creatoon
Copy link
Owner

@0xCipher-max I am not saying about the color, look at the border radius , make it like top (header ) one

@Creatoon
Copy link
Owner

@0xCipher-max you should have handle this issue on a separate branch, remember from next time.

@0xCipher-max
Copy link
Author

image
Can You please check this and tell me what else to modify?

@Creatoon
Copy link
Owner

@0xCipher-max send your email, will be having a meet with you

@0xCipher-max
Copy link
Author

Yaa sure!!
[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize the Landing Page
2 participants