Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplyfy the logic used in getting the text of input field in the search box. #19

Open
Creatoon opened this issue May 14, 2021 · 0 comments
Open

Simplyfy the logic used in getting the text of input field in the search box. #19

Creatoon opened this issue May 14, 2021 · 0 comments
Labels
feature New feature good first issue This issue is good for first timers question Further information is requested

Comments

@Creatoon
Copy link
Owner

Is your feature request related to a problem? Please describe.
Right now the function of getting the text from the input field is very large, and need shorter implementation in order to reduce code.

Describe the solution you'd like
Use the function onChange() on the input tag and handle the getting text by "event object".

Describe alternatives you've considered
This implementation needs some research about pros and cons, please raise any question.
@Creatoon Creatoon added good first issue This issue is good for first timers question Further information is requested feature New feature labels May 14, 2021
Repository owner locked and limited conversation to collaborators Jun 13, 2021
Repository owner unlocked this conversation Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature good first issue This issue is good for first timers question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Creatoon