Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BlockRepresentation a builder-style #251

Closed
wants to merge 1 commit into from

Conversation

democat3457
Copy link

Fixes #237

Although the issue isn't really a bug, I can see the use in having a chain-style return to allow for more efficient code. (So this is more of a feature suggestion)

I would imagine the other Representations would have to be matched for parity between them?

Fixes CraftTweaker#237 

Although the issue isn't really a bug, I can see the use in having a chain-style return to allow for more efficient code. (So this is more of a feature suggestion)
@SkySom
Copy link
Member

SkySom commented Sep 13, 2021

Sure I totally agree that builder style is nicer. Which is why 1.16 uses it. At this point all 1.12 docs uses normal setters and honestly I'm not willing to risk what changing the type could do at this point.

@SkySom SkySom closed this Sep 13, 2021
@democat3457
Copy link
Author

/shrug

It's not like this would affect backwards-compatibility though, since changing a type from void to BlockRepresentation wouldn't affect existing scripts. (It would direct the returned value to nothing, but it would still alter the variable used.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.12.2] [Issue?] Block-Constructor (Void Member)
2 participants