Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image #600

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Docker image #600

wants to merge 2 commits into from

Conversation

sfarrens
Copy link
Member

@sfarrens sfarrens commented Nov 16, 2022

Summary

closes #598

  • Added a Dockerfile for building Docker images with ShapePipe pre-installed
  • Added GitHub action for automatically building the Docker image when changes are merged to master

If you want to test things locally you can checkout this branch and do the following.

docker build -t shapepipe .

Note: This will take a while. If you are on an M1 Mac then add the argument --platform linux/amd64 after build.

Then you can launch a container.

docker run -it --rm shapepipe

You will find all of the ShapePipe files in /home. The shapepipe environment will already be available with all the dependencies installed.

To Do

  • Update Dockerfile with CANFAR-specific dependencies
  • Update GitHub action to also push the built image to the CANFAR container registry

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@sfarrens sfarrens added the enhancement New feature or request label Nov 16, 2022
@sfarrens sfarrens self-assigned this Nov 16, 2022
@sfarrens sfarrens marked this pull request as draft November 16, 2022 15:58
@sfarrens
Copy link
Member Author

I have informed Sébastien Fabbro about this PR and asked for some more info regarding the two "To Do" items.

@martinkilbinger
Copy link
Contributor

I tested it on my laptop, it seems to work, I can start the docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] shapepipe docker image for canfar
2 participants