Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error in jax_lensing/spectral.py #48

Open
NiallJeffrey opened this issue Aug 23, 2021 · 1 comment
Open

Possible error in jax_lensing/spectral.py #48

NiallJeffrey opened this issue Aug 23, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@NiallJeffrey
Copy link
Collaborator

NiallJeffrey commented Aug 23, 2021

https://github.com/CosmoStat/jax-lensing/blob/master/jax_lensing/spectral.py

Line 32 and 33. If this is meant to give ell (spherical harmonic), ell should be bounded by the maximum angular size nyquist*pixel_size and the smallest angular size pixel_size.

The current implementation gives an arbitrarily low minimum ell value for a finite sized patch.

@NiallJeffrey NiallJeffrey added the bug Something isn't working label Aug 23, 2021
@EiffL
Copy link
Member

EiffL commented Aug 25, 2021

Yeahm this is not really an error. it is what it is... ell=0 is still meaningfull, that's the constant of your field, but the user should just know that this is a flat sky approximation, and that the "ell" are not accurate toward low values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants