Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to the library for performing the sampling #45

Open
EiffL opened this issue Aug 2, 2021 · 1 comment
Open

Add functions to the library for performing the sampling #45

EiffL opened this issue Aug 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@EiffL
Copy link
Member

EiffL commented Aug 2, 2021

We currently rely on a lot of custom code that only appears in sample_maps.py for doing the sampling. This is not good. So for instance, if a user wants to sample a map in a notebook, they have to redefine everything.

We should add a set of functions to the library, so that you can for instance easily get the likelihood, and then just provide the likelihood and prior to a function that obtains samples for you.
@EiffL EiffL added the enhancement New feature or request label Aug 2, 2021
@EiffL EiffL mentioned this issue Aug 2, 2021
Closed
@EiffL
Copy link
Member Author

EiffL commented Aug 2, 2021

Also, this will allow to clean up sample_maps.py... which is... shall we say... a bit busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EiffL