Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion affects other 3-rd party animation libraries #74

Open
roteirod opened this issue Sep 10, 2019 · 9 comments
Open

Motion affects other 3-rd party animation libraries #74

roteirod opened this issue Sep 10, 2019 · 9 comments

Comments

@roteirod
Copy link

roteirod commented Sep 10, 2019

Hi there! First of all, I want to say that I love Motion a lot, it is a great thing which allows developers to do awesome stuff in their apps. I want to use it in our project a lot, but I am currently having several issues, and I would like to help finding and fixing them...

Along with Motion, I am using NVActivityIndicatorView, and I noticed that after several Motion transitions, my NVActivityIndicatorView animations work with some delay, and the more Motion transitions I perform, the worse it gets for NVActivityIndicatorView. Here is a video of a simple project I made. I tap "Animation" button to trigger NVActivityIndicatorView animation, it works fine. Then I do 10 Motion transitions and tap "Animation" again. You can see a slight freeze/delay. I repeat it 2 more times and it gets worse with every 10 transitions. In my real app with more complex views and transitions this thing is noticeable even after 2-3 transitions

video.mp4.zip
tabbarissue.zip

I discovered that HeroTransitions has the same issue:
HeroTransitions/Hero#256
And it happens not only with NVActivityIndicatorView but with other libraries too as you can see in that discussion

@OrkhanAlikhanov
Copy link
Contributor

Hey! Thank you for the issue! I've checked the both Motion and NVActivityIndicatorView sources (not tried your app, do not have proper xcode right now). I have no clue what happens there that causes lag in our side.

In the Hero issue you linked, someone posted that beginTime = CACurrentMediaTime() causes issue. Can you try . ballClipRotatePulse animation in your NVActivityIndicatorView? It does not use set beginTime = CACurrentMediaTime()

@roteirod
Copy link
Author

It acts the same with . ballClipRotatePulse...

@adamdahan
Copy link

adamdahan commented Sep 11, 2019

@roteirod This will take some time to solve. I will setup a workspace with NVActivityIndicatorView shortly.

@roteirod
Copy link
Author

@roteirod This will take some time to solve. I will setup a workspace with NVActivityIndicatorView shortly.

Hey! Do you have some update on the issue? Can't wait to start using your library in our app.. :)

@daniel-jonathan
Copy link
Member

Hi @roteirod looking at this today. Sorry for any delays.

@roteirod
Copy link
Author

Hey, guys! Any progress on this issue?

@daniel-jonathan
Copy link
Member

@roteirod Hey, sorry no, there hasn't been any progress. We have been so busy with other work, that we haven't had a chance to look into this.

@roteirod
Copy link
Author

@roteirod Hey, sorry no, there hasn't been any progress. We have been so busy with other work, that we haven't had a chance to look into this.

Ok... Let me know when you look into it

@amit2908
Copy link

Is this issue resolved ? I am looking for a library that doesn't breaks other animation libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants