Contract: emit activityKey
in NewCommitment event
#57
Labels
enhancement
New feature or request
Milestone
Currently, the
ActivityUpdated
andNewCommitment
events have the below signatures. Most importantly,NewCommitment
only emits theactivityName
param and not theactivityKey
param, which forces the subgraph to useactivityName
as the ID for theActivity
entity. Since the contract logic ensures there are no collisions betweenactivityName
s this is technically ok, but its more conventional to use something other than plaintext as an entity id.In the next version of the contract,
NewCommitment
should emit theactivityKey
param. For readability on block explorers, it can also emit the plaintextactivityName
param, though that does carry a small gas cost.The text was updated successfully, but these errors were encountered: