The Configurator Strikes Back #159

mrT23 · 2023-07-30T08:43:59Z

PR Type:

Enhancement

PR Description:

This PR is like a Swiss Army knife for our PR agent. It allows users to tweak any configuration parameter from 'configuration.toml' on-the-fly, right from the command line or bot commands. It's like giving our PR agent a new superpower, but without the need for a radioactive spider or a trip to Krypton.

PR Main Files Walkthrough:

-pr_agent/agent/pr_agent.py: The PR agent now takes additional arguments for each action, allowing users to modify settings on the fly.
-pr_agent/algo/utils.py: A new function update_settings_from_args has been added to parse and apply configuration changes from the command line arguments.
-pr_agent/cli.py: The command line interface now accepts configuration changes as arguments.
-pr_agent/servers/help.py: The help text has been updated to include instructions for modifying configuration settings.
-pr_agent/tools/pr_code_suggestions.py: The PR code suggestions tool now accepts additional arguments to modify settings.
-pr_agent/tools/pr_description.py: The PR description tool now accepts additional arguments to modify settings.
-pr_agent/tools/pr_information_from_user.py: The PR information from user tool now accepts additional arguments to modify settings.
-pr_agent/tools/pr_reviewer.py: The PR reviewer tool now accepts additional arguments to modify settings.
-pr_agent/tools/pr_update_changelog.py: The PR update changelog tool now accepts additional arguments to modify settings.
-pr_agent/settings/configuration.toml: The configuration file has been updated with new fields for each tool to accept extra instructions.

Extra human details:

was generated from cli with:

--pr_url=https://github.com/Codium-ai/pr-agent/pull/159
describe
--pr_description.extra_instructions="make the PR description funny"

github-actions · 2023-07-30T08:44:30Z

PR Analysis

🎯 Main theme: This PR introduces the ability to modify any configuration setting from the command line arguments. It also includes updates to the help text and the configuration file to reflect these changes.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
✨ Focused PR: Yes, the PR is focused as it concentrates on a single feature - allowing configuration settings to be updated from command line arguments. The title, 'update_settings_from_args', accurately represents the changes made in the PR.
🔒 Security concerns: No, the PR does not introduce any apparent security issues. The changes are primarily related to configuration settings and do not involve any sensitive data handling or operations that could potentially lead to security vulnerabilities.

PR Feedback

💡 General PR suggestions: The PR is generally well-structured and the changes are consistent across different files. However, it would be beneficial to include tests that verify the new functionality. Additionally, it would be helpful to provide a more detailed PR description to explain the changes and their impact on the existing codebase.

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe [-c]: Modify the PR title and description based on the contents of the PR. To get the description as comment instead of modifying the PR description, include the '-c' option.
/improve: Suggest improvements to the code in the PR. These will be provided as pull request comments, ready to commit.
/ask <QUESTION>: Pose a question about the PR.

mrT23 · 2023-07-30T08:59:18Z

PR Title

The Configurator Strikes Back

PR Type

Enhancement

PR Description

This PR is like a Swiss army knife for configuration settings! It allows users to modify any configuration parameter from 'configuration.toml' directly from the command line. This is the kind of flexibility that makes a contortionist jealous. It's like giving a chameleon a box of crayons and saying, 'Go nuts, buddy!'

PR Main Files Walkthrough

pr_agent.py: The main agent now takes arguments for each action, allowing for on-the-fly configuration changes.
utils.py: Added a function to update settings based on provided arguments. It's like a personal trainer for your settings.
cli.py: Command line interface now accepts configuration parameters. It's like a drive-thru for your settings.
help.py: Updated help text to include information about the new configuration options. It's like a user manual, but less boring.
pr_code_suggestions.py, pr_description.py, pr_information_from_user.py, pr_reviewer.py, pr_update_changelog.py: All these files now update settings from arguments. It's like a settings party, and everyone's invited!
configuration.toml: Added an 'extra_instructions' field for each command. It's like a secret menu for your commands.
pr_code_suggestions_prompts.toml, pr_description_prompts.toml, pr_reviewer_prompts.toml: Added condition to include extra instructions if provided. It's like a whisper in your AI's ear.

pr_agent/algo/utils.py

pr_agent/agent/pr_agent.py

pr_agent/algo/utils.py

mrT23 · 2023-07-30T09:24:51Z

Changelog updates:

2023-07-30

Enhanced

Added the ability to modify any configuration parameter on-the-fly from the command line or bot commands.
Updated the command line interface and help text to support configuration changes.
Each tool now accepts additional arguments to modify settings.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

mrT23 · 2023-07-30T09:26:59Z

CHANGELOG.md

+## 2023-07-30
+
+### Enhanced
+- Added the ability to modify any configuration parameter from 'configuration.toml' on-the-fly.
+- Updated the command line interface and bot commands to accept configuration changes as arguments.
+- Improved the PR agent to handle additional arguments for each action.


CHANGELOG.md update

… tr/edit_any_config_setting

pr_agent/tools/pr_update_changelog.py

pr_agent/tools/pr_description.py

pr_agent/tools/pr_code_suggestions.py

pr_agent/tools/pr_reviewer.py

mrT23 · 2023-07-30T19:05:33Z

/improve --pr_code_suggestions.num_code_suggestions=1

github-actions · 2023-07-30T19:06:18Z

pr_agent/tools/pr_update_changelog.py

        self.main_language = get_main_pr_language(
            self.git_provider.get_languages(), self.git_provider.get_files()
        )
-        self.commit_changelog = self._parse_args(args, settings)
+        update_settings_from_args(args)
+        self.commit_changelog = settings.pr_update_changelog.push_changelog_changes
        self._get_changlog_file()  # self.changelog_file_str
        self.ai_handler = AiHandler()
        self.patches_diff = None


Suggestion: The update_settings_from_args(args) function is called before the args variable is checked for None. This could lead to a TypeError if args is None. To prevent this, the function should be called after checking if args is not None.

Suggested change

self.main_language = get_main_pr_language(

self.git_provider.get_languages(), self.git_provider.get_files()

)

self.commit_changelog = self._parse_args(args, settings)

update_settings_from_args(args)

self.commit_changelog = settings.pr_update_changelog.push_changelog_changes

self._get_changlog_file() # self.changelog_file_str

self.ai_handler = AiHandler()

self.patches_diff = None

def __init__(self, pr_url: str, cli_mode=False, args: list = None):

self.git_provider = get_git_provider()(pr_url)

self.main_language = get_main_pr_language(

self.git_provider.get_languages(), self.git_provider.get_files()

)

if args is not None:

update_settings_from_args(args)

self.commit_changelog = settings.pr_update_changelog.push_changelog_changes

self._get_changlog_file() # self.changelog_file_str

self.ai_handler = AiHandler()

self.patches_diff = None

lufficc · 2023-08-10T11:33:01Z

Preparing pr description...

lufficc · 2023-08-10T12:11:07Z

Preparing pr description...

lufficc · 2023-08-10T12:17:20Z

Preparing pr description...

lufficc · 2023-08-11T02:26:37Z

Preparing pr description...

lufficc · 2023-08-11T02:30:22Z

Preparing pr description...

lufficc · 2023-08-11T02:45:12Z

Preparing pr description...

lufficc · 2023-08-11T02:47:45Z

Preparing pr description...

lufficc · 2023-08-11T03:40:44Z

Preparing pr description...

lufficc · 2023-08-11T06:14:47Z

Preparing pr description...

lufficc · 2023-08-11T06:27:22Z

Preparing pr description...

lufficc · 2023-08-11T06:55:25Z

Preparing pr description...

lufficc · 2023-08-11T07:13:25Z

Preparing pr description...

lufficc · 2023-08-11T07:18:51Z

Preparing pr description...

lufficc · 2023-08-11T07:23:45Z

Preparing pr description...

lufficc · 2023-08-11T07:40:49Z

Preparing pr description...

lufficc · 2023-08-11T07:44:19Z

Preparing pr description...

lufficc · 2023-08-11T07:45:27Z

Preparing pr description...

lufficc · 2023-08-11T07:47:39Z

Preparing pr description...

…tting The Configurator Strikes Back

update_settings_from_args

3daf949

mrT23 requested a review from okotek July 30, 2023 08:43

mrT23 changed the title ~~update_settings_from_args~~ The Configurator: Edit Any Setting On-the-Fly Jul 30, 2023

mrT23 added the enhancement New feature or request label Jul 30, 2023

mrT23 changed the title ~~The Configurator: Edit Any Setting On-the-Fly~~ The Configurator Strikes Back Jul 30, 2023

update_settings_from_args

42b047a

mrT23 commented Jul 30, 2023

View reviewed changes

pr_agent/algo/utils.py Outdated Show resolved Hide resolved

pr_agent/agent/pr_agent.py Show resolved Hide resolved

pr_agent/algo/utils.py Outdated Show resolved Hide resolved

mrT23 added 2 commits July 30, 2023 12:14

update_settings_from_args refactor

4f0fabd

Example args

a6ba8b6

Update CHANGELOG.md

a0cfe4b

mrT23 commented Jul 30, 2023

View reviewed changes

mrT23 added 2 commits July 30, 2023 12:27

final

e2d015a

Merge remote-tracking branch 'origin/tr/edit_any_config_setting' into…

0ad8dcd

… tr/edit_any_config_setting

okotek approved these changes Jul 30, 2023

View reviewed changes

mrT23 merged commit 5a181e5 into main Jul 30, 2023

mrT23 deleted the tr/edit_any_config_setting branch July 30, 2023 12:19

mrT23 mentioned this pull request Jul 30, 2023

[Feature Request] - Ability to customize the prompts #154

Closed

github-actions bot reviewed Jul 30, 2023

View reviewed changes

pr_agent/tools/pr_update_changelog.py Show resolved Hide resolved

pr_agent/tools/pr_description.py Show resolved Hide resolved

pr_agent/tools/pr_code_suggestions.py Show resolved Hide resolved

pr_agent/tools/pr_reviewer.py Show resolved Hide resolved

github-actions bot reviewed Jul 30, 2023

View reviewed changes

mrT23 mentioned this pull request Jul 30, 2023

[Feature Request] - Ability to configure GitHub App #155

Closed

yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024

Merge pull request Codium-ai#159 from Codium-ai/tr/edit_any_config_se…

2623db3

…tting The Configurator Strikes Back

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The Configurator Strikes Back #159

The Configurator Strikes Back #159

mrT23 commented Jul 30, 2023 •

edited

Loading

github-actions bot commented Jul 30, 2023

mrT23 commented Jul 30, 2023

mrT23 commented Jul 30, 2023

mrT23 Jul 30, 2023

mrT23 commented Jul 30, 2023

github-actions bot Jul 30, 2023

lufficc commented Aug 10, 2023

lufficc commented Aug 10, 2023

lufficc commented Aug 10, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

The Configurator Strikes Back #159

The Configurator Strikes Back #159

Conversation

mrT23 commented Jul 30, 2023 • edited Loading

PR Type:

PR Description:

PR Main Files Walkthrough:

Extra human details:

github-actions bot commented Jul 30, 2023

PR Analysis

PR Feedback

How to use

mrT23 commented Jul 30, 2023

PR Title

PR Type

PR Description

PR Main Files Walkthrough

mrT23 commented Jul 30, 2023

2023-07-30

Enhanced

mrT23 Jul 30, 2023

Choose a reason for hiding this comment

mrT23 commented Jul 30, 2023

github-actions bot Jul 30, 2023

Choose a reason for hiding this comment

lufficc commented Aug 10, 2023

lufficc commented Aug 10, 2023

lufficc commented Aug 10, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

lufficc commented Aug 11, 2023

mrT23 commented Jul 30, 2023 •

edited

Loading