Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update and Setup Rubocop #981

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codeclimate.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
engines:
rubocop:
enabled: true
channel: rubocop-0-49
channel: rubocop-1-56-3
bundler-audit:
enabled: true
flog:
Expand Down
96 changes: 14 additions & 82 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,87 +1,19 @@
AllCops:
TargetRubyVersion: 2.3
Exclude:
- 'db/schema.rb'
- 'db/migrate/*.rb'
- 'config/**/*'
- 'script/**/*'
- 'bin/**/*'
- 'node_modules/**/*'
- 'Gemfile'

Rails:
Enabled: true

Rails/TimeZone:
Enabled: false

Rails/Date:
Enabled: false

Rails/HttpPositionalArguments:
Enabled: false

Rails/SkipsModelValidations:
Enabled: false

Documentation:
Enabled: false
inherit_from: .rubocop_todo.yml

Lint/AmbiguousBlockAssociation:
Exclude:
- 'spec/**/*.rb'

Style/Semicolon:
AllowAsExpressionSeparator: true
require:
- rubocop-rails
- rubocop-rspec
- rubocop-capybara
- rubocop-factory_bot

Style/ClassAndModuleChildren:
Enabled: false

Style/EachWithObject:
Enabled: false

Style/FrozenStringLiteralComment:
Enabled: false

Style/StructInheritance:
Enabled: false

Layout/AlignParameters:
Enabled: false

Layout/ClosingParenthesisIndentation:
Enabled: false

Metrics/LineLength:
Max: 100

Metrics/MethodLength:
CountComments: false
Max: 25

Metrics/AbcSize:
Enabled: true
Max: 25
Exclude:
- 'app/controllers/stories_controller.rb'
- 'app/controllers/projects_controller.rb'
- 'app/presenters/activity_presenter.rb'

Metrics/ClassLength:
Enabled: true
Max: 110
Exclude:
- 'app/controllers/projects_controller.rb'
- 'app/controllers/teams_controller.rb'

Metrics/PerceivedComplexity:
Enabled: true
Max: 8

Metrics/CyclomaticComplexity:
Enabled: true
AllCops:
NewCops: enable
Exclude:
- 'spec/support/integration_helpers.rb'
- 'node_modules/**/*'
- 'db/**/*'
- 'config/**/*'
- 'bin/*'
- 'vendor/**/*'

Metrics/BlockLength:
Style/Documentation:
Enabled: false
Loading
Loading