Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Palette Switch Issue #4025

Closed
RohanSharma2598 opened this issue Jun 30, 2023 · 1 comment · Fixed by #4057
Closed

Palette Switch Issue #4025

RohanSharma2598 opened this issue Jun 30, 2023 · 1 comment · Fixed by #4057
Assignees
@cristian-ungureanu
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@RohanSharma2598
Copy link

Description

While Editing the Palette Switch Block, we get a link which we can click on to Edit the color Palette.
See: https://share.getcloudapp.com/v1uWNner

If, I am clicking on the link, I see the options to edit the color palette. There I see two Global Color Options, Base and Dark. If I select Dark to be the default color and publish the change, the palette switch doesn't work.
See: https://share.getcloudapp.com/E0uL9m4n

Step-by-step reproduction instructions

  1. Go to Header in Customizer and add a Palette Switch Block.
  2. Click on Edit Color Palettes Link
  3. Select the Dark Mode there and publish
  4. Try clicking on the Palette Switch link on the page

Screenshots, screen recording, code snippet or Help Scout ticket

Help Scout: https://secure.helpscout.net/conversation/2283157740/374409?folderId=212385

Environment info

No response

Is the issue you are reporting a regression

No
@RohanSharma2598 RohanSharma2598 added the bug This label could be used to identify issues that are caused by a defect in the product. label Jun 30, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Jun 30, 2023
@preda-bogdan preda-bogdan added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Jul 17, 2023
cristian-ungureanu pushed a commit that referenced this issue Aug 2, 2023
fix: confusing palette switch in customizer [#4025]
1880941
@cristian-ungureanu cristian-ungureanu mentioned this issue Aug 2, 2023
Merged
6 tasks
@cristian-ungureanu cristian-ungureanu linked a pull request Aug 2, 2023 that will close this issue
Fix for confusing palette switch in customizer #4057
Merged
6 tasks
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.6.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 22, 2023
@cristian-ungureanu cristian-ungureanu mentioned this issue Sep 19, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristian-ungureanu cristian-ungureanu

Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for confusing palette switch in customizer Codeinwp/neve
4 participants
@cristian-ungureanu @preda-bogdan @pirate-bot @RohanSharma2598