Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font size control to the site title #3914

Closed
stefan-cotitosu opened this issue Mar 27, 2023 · 6 comments
Closed

Add font size control to the site title #3914

stefan-cotitosu opened this issue Mar 27, 2023 · 6 comments
Assignees
Labels
customer report Indicates the request came from a customer. doc-created This label will be used after the doc-needed request has been satisfied. doc-needed This issue requires documentation updates or additions once it has been completed. neve-37 new feature Request for a new feature or functionality to be added to the project. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Milestone

Comments

@stefan-cotitosu
Copy link
Contributor

What problem does this address?

Some users ask us how to control the font-size of the site title. Currently, it works with custom code only.font size

What is your proposed solution?

Add a font-size control for the Site Title component into the Style tab, like it is for other header components.

Screen Capture on 2023-03-27 at 12-08-23

Requested here: https://secure.helpscout.net/conversation/2192260237/362887/

Previously requested here: https://github.com/Codeinwp/themes-internal/issues/147

@stefan-cotitosu stefan-cotitosu added the new feature Request for a new feature or functionality to be added to the project. label Mar 27, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Mar 27, 2023
@HardeepAsrani HardeepAsrani added this to the 3.7 milestone Jul 14, 2023
@HardeepAsrani HardeepAsrani added the doc-needed This issue requires documentation updates or additions once it has been completed. label Jul 19, 2023
@preda-bogdan preda-bogdan added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Jul 20, 2023
@cristian-ungureanu
Copy link
Contributor

Hey @HardeepAsrani, is it ok to add a typeface control like this one?
Screenshot 2023-08-02 at 14 40 36

We don't have a responsive number control so if we choose to have just the font size, I need to create one. I think the typeface control could be more useful.

And another question, if we add the font size for the title, should we do the same for the tagline?

Let me know what you think.

@HardeepAsrani
Copy link
Member

@cristian-ungureanu Might make sense to have it for both, I agree. For the control, we do have similar looking control being used for Logo Width, can't we use that instead of using the entire typeface control?

CCin @Codeinwp/design-team if they have any opinions about this.

@mghenciu
Copy link

mghenciu commented Aug 3, 2023

Overall, this would be a nice addition. But I think the most important things are in this order:

  1. have the Option to adjust only the font size with PX, REM or EM for the Title, depending on device
  2. have this option for the subtitle also device based
  3. have all the options including Font Weight, Line height and so on.

So in my opinion if we do just 1, or 1 + 2 -> this should be more than enough.

@cristian-ungureanu
Copy link
Contributor

After giving this another thought, I decided not to add the font size for the tagline. The main reason for it is that the tagline is in a <small> tag, and this tag has its font size relative to its parent. Its parent has the general font size so whenever you change that, the tagline will also increase its size.

@JohnPixle
Copy link

Makes sense @cristian-ungureanu ! 👍🏻

@AndreeaCristinaRadacina AndreeaCristinaRadacina added the doc-created This label will be used after the doc-needed request has been satisfied. label Aug 4, 2023
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer report Indicates the request came from a customer. doc-created This label will be used after the doc-needed request has been satisfied. doc-needed This issue requires documentation updates or additions once it has been completed. neve-37 new feature Request for a new feature or functionality to be added to the project. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

No branches or pull requests

8 participants