Skip to content
This repository has been archived by the owner on Oct 8, 2023. It is now read-only.

Set up Prettier and Eslint for the project and run it through the whole code-base (Pair or groups work) #222

Open
2 tasks
OlaShabalina opened this issue Oct 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@OlaShabalina
Copy link
Collaborator

I'm submitting a ...

  • feature request/bug report (a bit both I would say)

What is the current behavior?

Prettier and Eslint were installed but never set up properly. That's why we had to run Prettier manually all the time. I tried to configure them in the following PR - it did run well locally however it would need to format the whole codebase on deployment to pass the vercel check which was risky to do at that time:

image

Ideally we would need to have a group session to go through config (to customise Eslint as per our preferences) then run it through the whole codebase and fix issues along the way. Sometimes solution offered by Eslint is not the best solution - we we might need to come up with the walk-around for some cases.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

You can load the eslint branch from the following PR to check the results of it's run.

What is the expected behaviour?

No longer running Prettier for each page. Being prompted to fix format issues on the go.

Solution

  • Group (or pair) session to configure the Eslint - discussion which features we need, how we format the code, etc;
  • Running the confit through code base and fixing existing issues;

Link to Trello card: here

@OlaShabalina
Copy link
Collaborator Author

@OlaShabalina OlaShabalina added the enhancement New feature or request label Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant