Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle new lines in CSV validation script #121

Closed

Conversation

MichaelTamaki
Copy link

Correctly handle new lines in CSV validation script

Attempting to fix Github Action errors found where the CSV file new lines are not interpreted correctly.

If newline='' is not specified, newlines embedded inside quoted fields will not be interpreted correctly, and on platforms that use \r\n linendings on write an extra \r will be added. It should always be safe to specify newline='', since the csv module does its own (universal) newline handling.
https://docs.python.org/3/library/csv.html#csv.reader

We see that in the Google spreadsheet, there are some values that have new lines values in them.

Example failed run: https://github.com/CodeWithAloha/Hawaii-Zoning-Atlas/actions/runs/8231035064

@MichaelTamaki MichaelTamaki requested a review from a team as a code owner March 12, 2024 05:07
@MichaelTamaki
Copy link
Author

Closing -- This might not have been the correct problem

@MichaelTamaki MichaelTamaki deleted the fix-validation-script branch March 12, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants