Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI runs and spoiler deployment failing #301

Open
tooomm opened this issue Nov 5, 2023 · 4 comments
Open

CI runs and spoiler deployment failing #301

tooomm opened this issue Nov 5, 2023 · 4 comments

Comments

@tooomm
Copy link
Contributor

tooomm commented Nov 5, 2023

Recent runs started to fail and spoilers are not updated since 2 days:
image

@ebbit1q
Copy link
Member

ebbit1q commented Nov 5, 2023

yes, there seems to be a card without type line causing the script to break

@tooomm
Copy link
Contributor Author

tooomm commented Nov 12, 2023

Can we make it a warning instead?
An empty title is not that bad maybe.

If you know which card it is, you can also report it to Scryfall, they have a link at the bottom of each card:
image

@ebbit1q
Copy link
Member

ebbit1q commented Nov 13, 2023

it's a preview card, it's likely the type was simply not known yet at the time

@tooomm
Copy link
Contributor Author

tooomm commented Nov 19, 2023

Scryfall is quite good with their data, unusual that they have a picture but provide incomplete data otherwise. If we did report the faulty card, they would have resolved it within less than a day I guess.

Anyway, the script should not simply fail here.
We are ok with having a missing type, if we keep getting all the other updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants