Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: bootstrap: more robust implementation for ssh_merge (bsc#1230530) #1610

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Dev: bootstrap: more robust implementation for ssh_merge (bsc#1230530) #1610

merged 2 commits into from
Nov 13, 2024

Conversation

nicholasyang2022
Copy link
Collaborator

@nicholasyang2022
Dev: bootstrap: more robust implementation for ssh_merge (bsc#1230530)
7b97a22 
* Do not use legacy `write_remote_file`, which does not work well with
  `_guess_user_for_ssh`.
* Implement deduplication when merging known_hosts
@nicholasyang2022
unused code removal
1edd60a
@nicholasyang2022 nicholasyang2022 mentioned this pull request Nov 12, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.25%. Comparing base (a27e5ec) to head (1edd60a).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 54.49% <100.00%> (-0.01%) ⬇️
unit 52.15% <21.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 88.68% <100.00%> (+0.01%) ⬆️
crmsh/utils.py 66.66% <ø> (-0.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review November 12, 2024 08:17
liangxin1300 added a commit that referenced this pull request Nov 13, 2024
@liangxin1300
[crmsh-4.6] Dev: bootstrap: more robust implementation for ssh_merge …
2898bfd 
…(bsc#1230530) (#1611)

backport:

* #1610
@liangxin1300 liangxin1300 merged commit 0af43cf into ClusterLabs:master Nov 13, 2024
32 checks passed
@nicholasyang2022 nicholasyang2022 deleted the bsc_1230530_20241008_master branch November 26, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxin1300 liangxin1300 liangxin1300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasyang2022 @liangxin1300