Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Inconsistency in EvalAI-ngx. #255

Open
1 of 2 tasks
jayaike opened this issue Jan 4, 2020 · 6 comments
Open
1 of 2 tasks

Inconsistency in EvalAI-ngx. #255

jayaike opened this issue Jan 4, 2020 · 6 comments

Comments

@jayaike
Copy link
Contributor

jayaike commented Jan 4, 2020

I'm submitting a

(Check one with "x" from given options)

  • Bug report
  • Feature request

Current behavior

I noticed that in the EvalAI-ngx sometimes "state-of-the-art" is used, other times "state of the art" is used.

Expected behavior

Either "state of the art" or "state-of-the-art" should be used.

Which one should we use so we don't make it look inconsistent and I can make a pull request for it?

@jayaike
Copy link
Contributor Author

jayaike commented Jan 4, 2020

@jayaike
Copy link
Contributor Author

jayaike commented Jan 5, 2020

state-of-the-art was used in :

about.component.html line 10
get-involved.component.html line 11
home.component.html line 3

state of the art was used in

footer.component.html line 6
homemain.component.html line 3
auth.component.html line 27

@Suryansh5545

@Suryansh5545
Copy link
Member

Suryansh5545 commented Jan 5, 2020

Yea i Saw it Now.

@krtkvrm
Copy link
Member

krtkvrm commented Jan 6, 2020

@nsjcorps thanks for reporting this. If you are interested in fixing this issue, please let me know.

@jayaike
Copy link
Contributor Author

jayaike commented Jan 6, 2020

I created a PR for it already @vkartik97

#261

@jayaike
Copy link
Contributor Author

jayaike commented Jan 6, 2020

I think you should also take a look at #256 @vkartik97

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants