Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include start date when saving diagnostics as NCDataset #879

Closed
ph-kev opened this issue Oct 22, 2024 · 2 comments
Closed

Include start date when saving diagnostics as NCDataset #879

ph-kev opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ph-kev
Copy link
Member

ph-kev commented Oct 22, 2024

When the diagnostics are saved as NCDatasets after a simulation, the start date is not available in the attributes.

The start dates should be saved in the attributes in the NCDataset so that one doesn't need to go to the simulation that generate the data and find the start date of the simulation.

@ph-kev ph-kev added the enhancement New feature or request label Oct 22, 2024
@Sbozzolo
Copy link
Member

We can fix this by adding a new argument to NetCDFWriter in ClimaDiagnostics. This argument will be something like more_attributes, a dictionary that maps keys to attributes, and we write those attributes as global attributes the first time we write the a NetCDF file.

@AlexisRenchon
Copy link
Member

Done in #893 and ClimaDiagnostics CliMA/ClimaDiagnostics.jl#94 + CliMA/ClimaDiagnostics.jl#96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants