Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.12 #151

Open
ChrisNeedham24 opened this issue Sep 22, 2024 · 2 comments
Open

Upgrade to Python 3.12 #151

ChrisNeedham24 opened this issue Sep 22, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation infrastructure What makes the system tick refactor No new functionality

Comments

@ChrisNeedham24
Copy link
Owner

  • Jump straight from 3.10 to 3.12 - there wasn't anything in 3.11 that I thought was worth upgrading for.
  • Update documentation to reflect that 3.12 is required.
  • Consider whether there are places where we could declare custom types (e.g. type Location = Tuple[int, int])
  • Replace usages of split_list_into_chunks() in calculator.py with itertools.batched() - can remove the custom function and its test afterwards.
  • Determine whether there are any multi-line f-strings we could use.
  • Deal with any other warnings that may appear.
@ChrisNeedham24 ChrisNeedham24 added documentation Improvements or additions to documentation refactor No new functionality infrastructure What makes the system tick labels Sep 22, 2024
@ChrisNeedham24
Copy link
Owner Author

Will also need to update nuitka since the current version only experimentally supports 3.11/3.12.

@ChrisNeedham24
Copy link
Owner Author

Acceptance Criteria:

  • Bump Python version in GitHub actions (.github/workflows/ci.yml and .github/workflows/bundle.yml) to the latest available patch version of 3.12.
  • Update README.md and CONTRIBUTING.md to refer to Python 3.12 rather than 3.10.
  • Investigate and determine whether there are any places where custom types (e.g. type Location = Tuple[int, int] would make sense, and implement them if so.
  • Replace usages of split_list_into_chunks() in calculator.py with itertools.batched().
  • Remove the split_list_into_chunks() function from calculator.py and its test from test_calculator.py.
  • Investigate and determine whether there are any cases where we would benefit from using multi-line f-strings, and implement them if so.
  • Remove any warnings that appear in your IDE (PyCharm is usually good for this).

@ChrisNeedham24 ChrisNeedham24 added the hacktoberfest Issues that are appropriate for new contributors label Sep 30, 2024
@ChrisNeedham24 ChrisNeedham24 removed the hacktoberfest Issues that are appropriate for new contributors label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation infrastructure What makes the system tick refactor No new functionality
Projects
None yet
Development

No branches or pull requests

1 participant