Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PacketHandlerThread should have an option to disable warn_unhandled #8

Open
cboulay opened this issue Mar 15, 2024 · 0 comments
Open

Comments

@cboulay
Copy link
Contributor

cboulay commented Mar 15, 2024

In situations where your device is sending data in multiple modalities (to Central for recording) but your pycbsdk is only interested in some of that data, currently we get lots of warnings about unhandled packets.

A current solution is to register a do-nothing callback for that packet type.

However, it would be nice if the PacketHandlerThread simply had an option to not warn about unhandled packets.

e.g., in the following:

elif b_debug_unknown:

We could simply make that

elif b_debug_unknown and self._b_warn_unhandled:

where _b_warn_unhandled is set during thread initialization. This is set on device connection and cannot be modified while running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant