Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve targetCollection Annotation Detection #190

Open
thehabes opened this issue Feb 27, 2024 · 1 comment
Open

Improve targetCollection Annotation Detection #190

thehabes opened this issue Feb 27, 2024 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@thehabes
Copy link
Member

It is entirely too easy to break the Gloss List and Gloss List Item templates by making a poor targetCollection Annotation.

What they MUST look like

{
	"@type": "Annotation",
	"target": "https://devstore.rerum.io/v1/id/614362c3e74876243131a4e0",
	"body": {
		"targetCollection": "GoG-Named-Glosses"
	}
}

What they COULD look like on accident and you have no control over it because devs can do whatever they want because they know stuff.

{
	"@type": "Annotation",
	"target": "I am reckless with my target",
	"body": {
		"targetCollection": "GoG-Named-Glosses"
	}
}
{
	"@type": "Annotation",
	"target": "https://fooled.ya/haha/123123",
	"body": {
		"targetCollection": "GoG-Named-Glosses"
	}
}

The templates fail to load with a silent error when they pull in one of these bad targetCollection Annotations. The app should ignore targetCollection Annotations that are clearly invalid (the target will not be a URI or may not make sense because it should be targeting RERUM data).

@thehabes thehabes added bug Something isn't working enhancement New feature or request labels Feb 27, 2024
@cubap
Copy link
Member

cubap commented Nov 5, 2024

Bump for@cubap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants