WIP on Issue 57 extend line web api #64
Merged
+198
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* /manifest route prototype (#6) (#10) * More set up for testing * Now this is something worth bringing to the table to talk about. * Now this is something worth bringing to the table to talk about. * Hands up, no further until after stand up. Make sure this is on a better looking track. * Better organization. Better notes and textual queues to what is going on. * oo get that low hanging coverage * test wording hint * If I typed out this comment your would TLDR and move on so...here's some stuff. * Fancy. Tests are segregated and can be called individually or all together. * Cleaning up * cleanup getting ready for PR * Documentation for sanity Co-authored-by: Bryan Haberberger <[email protected]> * WIP on issue 19 (#32) * added initial code for issue19 page/id * removed the test cases package in page/tests-not required now * updated on the previous comments on issue * WIP on Issue 21 (#33) * Added the initial codebase to implement the GET/line/{lineid} and REST responses * Added the Code Changes Documentation * Delete Code Changes Documnetation.md * Updated the code with the requested comments and added the end to end,exists and functionality test cases * Added the Read me file , updated the code for the requested changes --------- Co-authored-by: BhanuKandula5030 <[email protected]> Co-authored-by: Bryan Haberberger <[email protected]> * WIP on Issue 2 (#34) * Initial commit on Issue #2, largely duplicating /manifest code to new /project directory * /project sends local dummy JSON data * Added tests to project directory * Addressed comment on mockPause() in project.mjs --------- Co-authored-by: Bryan Haberberger <[email protected]> * Manifest endpoint cleanup (#47) * clean it up! * documentation * documentation and cleanup * documentation and cleanup * big merge cleanup --------- Co-authored-by: Patrick Cuba <[email protected]> Co-authored-by: Sandeep Kumar Sutharapu <[email protected]> Co-authored-by: BhanuKandula5030 <[email protected]> Co-authored-by: BhanuKandula5030 <[email protected]> Co-authored-by: Leandru Martin <[email protected]>
…he functionality unit tests to pass the different query parameters
…action of teh controller and implemented the mock test cases and addressed the end point parameters
thehabes
requested changes
Mar 18, 2024
leandrumartin
approved these changes
Mar 18, 2024
cubap
requested changes
Mar 18, 2024
cubap
reviewed
Mar 18, 2024
cubap
reviewed
Mar 18, 2024
cubap
requested changes
Mar 19, 2024
There was a problem hiding this comment.
This definitely isn't the last time we'll be through this code, so there are some things that need to be accepted as just incomplete. I would never hold back an entire PR just for semicolons, but it has gone back and forth so many times here that I am worried about your development environment/workflow.
If you don't address anything else but can confidently remove the ";" that are unneeded, I will endorse pulling this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
Updated Endpoint Logic: Refactored the GET /line/{id} endpoint in the index.js file and also updated the line.mjs file.
Database Abstraction: Introduced a database controller abstraction with db.getByID() and db.find({property: match}) methods, simulating the connection to an actual database.
Alternate Returns for Query Parameters: Implemented logic to handle query parameters such as ?text=blob, ?image=full, ?image=line, and ?lookup=project mentioned in the issue.
Functionality unit tests : Implemented the tests to ensure the different query parameters are working fine.
Database Mock: Created a simple database mock (db.js) to simulate database interactions for testing purposes.