-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors should be on by default and output stack trace #28
Comments
Yeah this is sort of a pain point in the code right now. The tricky part with it is that Promises make error handling pretty tricky because if you throw an error it doesn't always cause the nodejs process to die and exit. And since we're using a lot of Promises with SystemJS, we'd just have to take that into account. |
@joeldenning I'm guessing you are talking about the more general problem of handling async exceptions? That could be addressed without major hassle, but quite frankly, some extensive refactoring with unit tests would be ideal, and I feel like these |
Agreed. What started as a pet-project is getting more and more important for my workflow as well. I think a refactoring + tests is in order. |
Maybe after #27 is merged in we can start doing a series of small refactoring prs. |
To make debugging more convenient (especially for the CLI), I think it would be beneficial to add
console.error
calls by default. Basically switching every occurrence oferrCallback(ex)
toif (typeof errCallback === 'function') { errCallback(ex) } else { console.error(ex.stack) }
(Assuming the default forerrCallback
is changed to undefined.)The text was updated successfully, but these errors were encountered: