Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3483: Fixed date format #1265

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

loganbertram
Copy link
Contributor

JIRA Ticket:
BB2-3483

What Does This PR Do?

Fixes access grant expiration date to use ISO-8601, per FHIR expectations.

What Should Reviewers Watch For?

Check access grant expiration format.

If you're reviewing this PR, please check for these things in particular:

Validation

Get an access token and confirm that the "access_grant_expiration" is in ISO-8601 format.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Copy link
Contributor

@bwang-icf bwang-icf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks right to me!

@loganbertram loganbertram enabled auto-merge (squash) November 14, 2024 18:11
@loganbertram loganbertram merged commit 409d025 into master Nov 14, 2024
6 checks passed
@loganbertram loganbertram deleted the loganbertram/BB2-3483-ag-expiration-format branch November 14, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants