Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Feedback on trigger execution #30

Open
maltfield opened this issue Jul 9, 2022 · 1 comment
Open

GUI Feedback on trigger execution #30

maltfield opened this issue Jul 9, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@maltfield
Copy link
Member

Problem: The GUI app currently doesn't display anything when a USB removal event causes a trigger to be executed. This means that, if it fails to execute, the user sees nothing happening at all.

Solution: We need to display a notification in the GUI saying that the trigger was (attempted to be executed)

@maltfield
Copy link
Member Author

This is already done in the CLI. When a USB hotplug event is detected, it will output something like this

DEBUG: called hotplugCallbackNix()
context:|<usb1.USBContext object at 0x730a750bb250>|
device:|Bus 002 Device 002: ID 0bda:0328|
event:|2|
usb1.HOTPLUG_EVENT_DEVICE_LEFT:|2|
calling <bound method BusKill.triggerLin of <packages.buskill.BusKill object at 0x730a76aa6510>>
DEBUG: BusKill lockscreen trigger executing now

This also gets logged to the debug log file.

We need to display something similar to this in the GUI. Perhaps with a toast message of some kind. I'm not a fan of KivyMD, but perhaps I could implement something similar to this

@maltfield maltfield added the enhancement New feature or request label Jul 9, 2022
@maltfield maltfield self-assigned this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant