Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to 2.5 #487

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

JieXiong9119
Copy link
Contributor

Update examples to 2.5 as it's released

@JieXiong9119 JieXiong9119 added enhancement Non-breaking Change Schema: Documentation Update to BuildingSync's documentation/annotations labels Sep 28, 2023
@JieXiong9119 JieXiong9119 self-assigned this Sep 28, 2023
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks, @JieXiong9119.

Copy link
Contributor

@ThibaultMarzullo ThibaultMarzullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @JieXiong9119.
One remaining item is updating the DOE Reference Primary School L100 and L200 Python notebook and we're good to go.

@JieXiong9119
Copy link
Contributor Author

Looks good, thanks @JieXiong9119. One remaining item is updating the DOE Reference Primary School L100 and L200 Python notebook and we're good to go.

Updated. check it out!

@JieXiong9119 JieXiong9119 merged commit 5717f66 into develop-v2 Sep 29, 2023
3 checks passed
@JieXiong9119 JieXiong9119 deleted the feat/update-examples-to-2.5 branch September 29, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Non-breaking Change Schema: Documentation Update to BuildingSync's documentation/annotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants