Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log into the Order Notes, any blocks from the rate limit plugin #13

Open
danfeeley opened this issue Nov 3, 2022 · 2 comments
Open

Comments

@danfeeley
Copy link

Hey there,

Testing out the plugin and its nice and simple. May I suggest to make the troubleshooting process of failed orders easier that you write into the order notes of the failed order the fact that the rate limit plugin was the one that blocked the order. This way blocked orders that are really false positives can be identified easier by someone providing support.

BrianHenryIE added a commit that referenced this issue Dec 20, 2022
Incomplete contribution towards #13.
@BrianHenryIE
Copy link
Owner

Hey,

When the Place Order action is blocked, there is no order yet created for the current cart. I guess there is maybe already some recent orders placed by the same IP address. I'll take a look at adding order notes to those related orders and adding an admin notice to alert the shop manager.

There is already a small log added when there is a blocked attempt. Unfortunately, you would need to be reviewing the plugin's logs to see that. There are a couple of changes I need to make to the logging library itself to help make those more prominent.

@danfeeley
Copy link
Author

I believe woo creates the order, sets the order state to pending payment, then hands it off to the payment gateway process. At least this is what I have observed through the orders and order notes and watching payments happen via a paypal gateway. So you will get a few failed notice from the payment gateway on at least one order prior to where you will outright block. This is mostly for the good-guy payments where they are being blocked by the customers fat-fingering. I am assuming you intercept and break the payment gateway process. So subsiquent orders not created and blocked from the real bad guy, if not generated, is fine if that is only logged in a debug log.

I am just pointing out the more obvious false-positives from customers screwing up, and suggesting a more obvious way a non-technical person would be able to triage the problem by just looking at the failed order that should be on record for the good-guy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants