Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vouching Functionality #5

Open
4 tasks
RonTuretzky opened this issue Nov 2, 2024 · 1 comment
Open
4 tasks

Vouching Functionality #5

RonTuretzky opened this issue Nov 2, 2024 · 1 comment
Assignees

Comments

@RonTuretzky
Copy link
Contributor

RonTuretzky commented Nov 2, 2024

These are the entrypoints
vouch(bytes32 projectApprovalAttestation, bytes32 identityAttestation)
vouch(bytes32 projectApprovalAttestation)

In any given vouch , there are 4 possible scenarios:

  • Voucher has already vouched and project has already been vouched by someone else
    • No need to prove the voucher's identity or the project's validity
  • Voucher has not already vouched and the project has already been vouched by someone else
    • Need to prove the voucher's identity , don't need to prove project
  • Voucher has already vouched and the project has not already been vouched for
    • Need to prove the project's validity
  • Voucher has not already vouched and the project has not been vouched for
    • Need to prove the voucher's validity and the project's validity
      The following flowchart explains the process that must be done for each scenario.
      vouch(bytes32 approvedProjectAttestation)

This function should

  • Add the project to currentProjects if the project is not already included
  • Should utilize `validateProject(bytes32 approvedProjectAttestation) (Dependency on validateProject #3 validateOptimismVoter #4 , please proceed with empty function declarations if blocked)
  • should initialize projects expiry
  • unit tests
@RonTuretzky RonTuretzky converted this from a draft issue Nov 2, 2024
@RonTuretzky RonTuretzky mentioned this issue Nov 2, 2024
2 tasks
@RonTuretzky RonTuretzky assigned hudsonhrh and RonTuretzky and unassigned hudsonhrh Nov 2, 2024
@WillyDallas
Copy link

should also

  • increment the number of vouches a project has

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants