Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic result #86

Merged
merged 9 commits into from
Jan 24, 2024
Merged

Dynamic result #86

merged 9 commits into from
Jan 24, 2024

Conversation

Hendrik-code
Copy link
Collaborator

PanopticaResult.py completely overhauled, making it a lot more automatic.
Makes it way easier to define new metrics.
Custom Exception added for when a metric (or sub-metric) cannot be calculated.

@Hendrik-code
panoptic_result overhauled, now works dynamically based on dependanci…
63b5f87 
…es, got way easier to add new metrics, pipeline intermediate steps are still a bit janky
@Hendrik-code
polished dynamic result object. added global dice score, added center…
293156e 
…lineDSC, fixed some bugs, added unit tests for the new panopticaresult object
@Hendrik-code Hendrik-code added the enhancement New feature or request label Jan 23, 2024
@Hendrik-code Hendrik-code self-assigned this Jan 23, 2024
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 23, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code Hendrik-code linked an issue Jan 23, 2024 that may be closed by this pull request
[feature request] calculate result with multiple evaluation thresholds #60
Open
@Hendrik-code Hendrik-code removed a link to an issue Jan 23, 2024
[feature request] calculate result with multiple evaluation thresholds #60
Open
@Hendrik-code Hendrik-code linked an issue Jan 23, 2024 that may be closed by this pull request
[feature request] the result object printing code and to_dict method are not dry #34
Closed
@Hendrik-code Hendrik-code removed a link to an issue Jan 23, 2024
[feature request] the result object printing code and to_dict method are not dry #34
Closed
@Hendrik-code
merged matchingmetric and listmetric into one called Metric, fixed bu…
a1866e3 
…g where metric computation error reason was not shown properly. started unittest for datatypes
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 23, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 23, 2024

🤖 I will now format your code with black. Check the status here.

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 23, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@neuronflow
Copy link
Contributor

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jan 23, 2024

🤖 I will now format your code with black. Check the status here.

@neuronflow
Copy link
Contributor

@Hendrik-code will this close #37 ?

@neuronflow
Copy link
Contributor

probably also this one: #34 ?

This was linked to issues Jan 23, 2024
[feature request] the result object printing code and to_dict method are not dry #34
Closed
[feature request] Global metrics #37
Closed
@neuronflow neuronflow merged commit 8b7c47b into main Jan 24, 2024
4 checks passed
@neuronflow neuronflow deleted the dynamic_result branch January 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Hendrik-code Hendrik-code

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@Hendrik-code @neuronflow