Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated markup does not include all properties completed #14

Open
AlasdairGray opened this issue Apr 29, 2020 · 0 comments
Open

Generated markup does not include all properties completed #14

AlasdairGray opened this issue Apr 29, 2020 · 0 comments
Labels
bug Something isn't working priority: high

Comments

@AlasdairGray
Copy link
Member

I completed the form for the GeneRecord profile. I included various Recommended and Optional properties. The generated markup was as follows

<script type="application/ld+json" >
{
  "@context": "http://schema.org",
  "@id": "https://www.example.com/Gene-BRCA1",
  "@type": "DataRecord",
  "dct:conformsTo": "https://bioschemas.org/profiles/DataRecord/0.2-DRAFT-2019_06_14",
  "identifier": "https://www.wikidata.org/wiki/Q227339",
  "mainEntity": {
    "@type": "Gene",
    "dct:conformsTo": "https://bioschemas.org/profiles/Gene/0.7-RELEASE",
    "identifier": "Q227339",
    "sameAs": [
      "https://meshb.nlm.nih.gov/#/record/ui?ui=D019398",
      "https://www.ncbi.nlm.nih.gov/nuccore/NR_027676",
      "http://identifiers.org/ensembl/ENSG00000012048",
      "https://www.ncbi.nlm.nih.gov/gene/672"
    ]
  },
  "sameAs": [
    "http://identifiers.org/ncbigene/672"
  ]
}
</script >

This is missing the following properties which were completed in the form: description, encodesBioChemEntity, isPartOfBioChemEntity, url, alternateName, image, taxonomicRange.

Looking at the web developer console on Firefox, I can see that it includes all the expected properties

{
  "@context": "http://schema.org",
  "@type": "DataRecord",
  "dct:conformsTo": "https://bioschemas.org/profiles/DataRecord/0.2-DRAFT-2019_06_14",
  "identifier": "https://www.wikidata.org/wiki/Q227339",
  "mainEntity": {
    "@type": "Gene",
    "dct:conformsTo": "https://bioschemas.org/profiles/Gene/0.7-RELEASE",
    "description": "protein-coding gene in the species Homo sapiens",
    "encodesBioChemEntity": [
      "https://www.wikidata.org/wiki/Q17487737"
    ],
    "identifier": "Q227339",
    "isPartOfBioChemEntity": [
      "https://www.wikidata.org/wiki/Q220677"
    ],
    "name": "BRCA1",
    "url": "https://www.wikidata.org/wiki/Q227339",
    "alternateName": [
      "breast cancer 1, early onset",
      "BRCAI",
      "BRCC1",
      "BROVCA1",
      "IRIS",
      "PNCA4",
      "PPP1R53",
      "PSCP",
      "RNF53",
      "FANCS",
      "breast cancer 1",
      "BRCA1, DNA repair associated",
      "BRCA1 DNA repair associated"
    ],
    "image": {
      "@type": "ImageObject",
      "@id": "https://upload.wikimedia.org/wikipedia/commons/thumb/e/e1/Protein_BRCA1_PDB_1jm7.png/220px-Protein_BRCA1_PDB_1jm7.png"
    },
    "taxonomicRange": [
      "https://www.wikidata.org/wiki/Q15978631"
    ],
    "sameAs": [
      "https://meshb.nlm.nih.gov/#/record/ui?ui=D019398",
      "https://www.ncbi.nlm.nih.gov/nuccore/NR_027676",
      "http://identifiers.org/ensembl/ENSG00000012048",
      "https://www.ncbi.nlm.nih.gov/gene/672"
    ]
  },
  "sameAs": [
    "http://identifiers.org/ncbigene/672"
  ],
  "@id": "https://www.example.com/Gene-BRCA1"
}

Why is the displayed generated markup not including all the properties?

@AlasdairGray AlasdairGray added bug Something isn't working priority: high labels Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high
Projects
None yet
Development

No branches or pull requests

1 participant