Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch scripts for linux32 and linux64 #19

Open
BinkanSalaryman opened this issue Apr 21, 2020 · 5 comments
Open

Add launch scripts for linux32 and linux64 #19

BinkanSalaryman opened this issue Apr 21, 2020 · 5 comments

Comments

@BinkanSalaryman
Copy link
Owner

I think the title says it all...

@jrrawlings
Copy link

jrrawlings commented Feb 9, 2022

I can confirm that this worked for me on Manjaro:
java -Djava.library.path=natives/linux64 -jar "Discord Audio Stream Bot.jar"

Looking at your win64 script I am not sure what the "exports" variable is doing but I didn't need it. To make it match the formatting of your win64 script we could have:

#!/bin/bash
natives=natives/linux64/
java -Djava.library.path=$natives -jar "Discord Audio Stream Bot.jar"

The jar could also easily be a variable the same way natives has been, though I didn't set it that way on my end. Naturally a linux32 script could be made that is almost exactly the same with the line natives=natives/linux32/

Very few people have 32 bit Linux but maybe somebody with an old raspberry pi or whatever will appreciate it.

Combined with Helvum and Pipewire this makes for an excellent workaround for Discord's lack of audio when streaming on Linux.

@BinkanSalaryman
Copy link
Owner Author

For exports variable see #61. I'm currently in hospital for therapy to cope with my childhood trauma & depression - thus I'm sorry that I can't put a little update out using my phone. Your cooperation is much appreciated though. I'l leave this ticket open until the next release comes with linux scripts added. Ok?

@jrrawlings
Copy link

No worries, get feeling better.

For when you're able to come back around to this from what I can tell #61 may be Windows specific, or at least the mitigation would be different on Linux if we assume it needs to be fixed. I didn't have any issue without it, and attempting to add --add-exports java.desktop/com.sun.java.swing.plaf.windows=ALL-UNNAMED in my arguments just yields this error:

WARNING: package com.sun.java.swing.plaf.windows not in java.desktop

It's probably best to not bother with a fix until somebody reports a specific error with the Linux version, as I'm not sure what would need to be set as a speculative fix without one. What I am reading says this module is meant to change the look of the UI, and mine already did fine with getting themed by my system.

@JohnnyPrimus
Copy link
Contributor

JohnnyPrimus commented Dec 15, 2023

#82 i think addresses this issue, per comment above it adds check before including the swing.plaf.windows export

@BinkanSalaryman
Copy link
Owner Author

#82 i think addresses this issue, per comment above it adds check before including the swing.plaf.windows export

Looks good, though the code in build.gradle is only for running the program with gradle (from source code within the IDE). As for the compiled version/release, I assume a short shell script calling java/javaw on the jar is is enough to get it working. Though the tricky part there is checking for architecture bits for the correct bass library natives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants