wr-419: Display notification about New articles written by followed authors on all pages #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PablloZz
commented
Sep 29, 2023
PablloZz
commented
…-writorium into development
…-writorium into fix/wr-419-display-notification-about-new-articles-written-by-followed-authors-on-all-pages
PablloZz
requested review from
andanf-e,
nickolay-grechkin and
WilhelmWesser
andanf-e
reviewed
Sep 29, 2023
backend/src/db/migrations/20230928125310_update_user_achievements_description.ts
Outdated
Show resolved
Hide resolved
backend/src/db/migrations/20230929065718_update_user_achievements_description.ts
Outdated
Show resolved
Hide resolved
backend/src/db/migrations/20230929065718_update_user_achievements_description.ts
Outdated
Show resolved
Hide resolved
| @@ -40,8 +47,24 @@ const useArticlesFeedRoom = (): void => { | |||
| articlesSocket?.on( | |||
| NEW_ARTICLE, | |||
| (newArticle: ArticleSocketEventPayload[typeof NEW_ARTICLE]) => { | |||
| if (location.pathname === AppRoute.ARTICLES) { | |||
| void dispatch(articleActions.addArticle(newArticle)); | |||
| if (user?.id === newArticle.socketUserId) { | |||
There was a problem hiding this comment.
I am not sure why we need to send socketUserId in the event's payload, can't it be
if (user?.id === newArticle.article.id) return ? Maybe I misunderstood something 😅
There was a problem hiding this comment.
In this case we only check the author of the article, but on the server we loop through all the sockets in the namespace and send to each user info about each socket on every loop cycle (for example if we have 5 sockets each user will get 5 payloads), so if only one user follows the author, every user will be notified of this publication due this one payload from that user.
There was a problem hiding this comment.
Maybe you should cooperate with @canterbery, your tasks seem to be related #458
andanf-e
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.