Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/177-createdby-createdon #191

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Feature/177-createdby-createdon #191

wants to merge 3 commits into from

Conversation

AyTee001
Copy link
Collaborator

@AyTee001 AyTee001 commented Sep 23, 2023 •
edited
Loading

@AyTee001 AyTee001 added the enhancement New feature or request label Sep 23, 2023
@AyTee001 AyTee001 self-assigned this Sep 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tatianahutii
tatianahutii requested changes Sep 26, 2023
View reviewed changes
backend/LeetWars.Core/LeetWars.Core.DAL/Interfaces/IUidProvider.cs
@@ -0,0 +1,8 @@
namespace LeetWars.Core.DAL.Interfaces
{
public interface IUidProvider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caanot we reuse our existing UserProvider?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our existing provider's implementation in our app depends on the dbcontext to be already initialized, creating a circular dependency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rework it to work in your way? we need to combine them as for now we are having 2 providers for the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illusion4 Illusion4 Illusion4 approved these changes

@Den313 Den313 Awaiting requested review from Den313

@tatianahutii tatianahutii Awaiting requested review from tatianahutii

Requested changes must be addressed to merge this pull request.

Assignees

@AyTee001 AyTee001

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyTee001 @tatianahutii @Illusion4