Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test current version before releasing #302

Closed
8 tasks done
haesleinhuepf opened this issue Jan 20, 2024 · 3 comments · Fixed by #315
Closed
8 tasks done

Test current version before releasing #302

haesleinhuepf opened this issue Jan 20, 2024 · 3 comments · Fixed by #315

Comments

@haesleinhuepf
Copy link
Member

haesleinhuepf commented Jan 20, 2024

I'm not sure if all use cases were properly tested. It would be cool if someone volunteers for testing them before #281 , as the tool is downloaded and used by quite some folks.

  • 2D labels
  • 3D labels
  • 2D + time
  • 3D + time
  • points
  • surface
  • points + time ? (bf09d79)
  • surface + time ? (9cf6704)

For the last tests, example data might be necessary (see also #301 )

Thanks!

@Cryaaa
Copy link
Collaborator

Cryaaa commented Apr 23, 2024

I had made some progress on this issue but one Issue is that the napari-skimage-regionprops function show_table is incompatible with surface layers currently. I have made a suggestion to fix it as a PR but until this gets merged and released we will need to either keep the newest cluster plotter release on hold or find a workaround for showing the table..

@Cryaaa
Copy link
Collaborator

Cryaaa commented Apr 24, 2024

@zoccoler Have you tested the new features manually yet? I don't think the plugin will work for the surface layer as expected because as soon as you perform dimension reduction or clustering on the surface layer the show_table function will erase the surface layer data.... I don't know if you would prefer just to do a workaround which I could get started on or if we should wait until the suggested PR is merged in napari-skimage-regionprops?

@zoccoler
Copy link
Collaborator

Hi @Cryaaa ,

I tried to fix that PR today, but I did not try that branch with the napari-clusters-plotter.
If you have some time, could you test if it would work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants