Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question related to the loss calculation #28

Open
zeyuliu1037 opened this issue Nov 19, 2024 · 0 comments
Open

Question related to the loss calculation #28

zeyuliu1037 opened this issue Nov 19, 2024 · 0 comments

Comments

@zeyuliu1037
Copy link

Hi, thank you for sharing the great code base!!

I have one question related to the loss calculation. Could you tell me why the average loss is calculated across all segments during training, but only the loss from the last segment is used as the evaluation loss or perplexity? I understand the average loss during the training, but shouldn't we also calculate the average loss during the test to have a fair comparison with other methods that do not segment the data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant