Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new version #1

Open
BenjaminDoran opened this issue Aug 9, 2023 · 7 comments
Open

Register new version #1

BenjaminDoran opened this issue Aug 9, 2023 · 7 comments

Comments

@BenjaminDoran
Copy link
Owner

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Error while trying to register: "Tag with name v0.1.1 already exists and points to a different commit"

@BenjaminDoran
Copy link
Owner Author

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/89342

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.2 -m "<description of version>" fde2c551cbf3dc47833bc1b452956d3e76125156
git push origin v0.1.2

Also, note the warning: This looks like a new registration that registers version 0.1.2.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@BenjaminDoran
Copy link
Owner Author

@JuliaRegistrator register

Dev (v0.2) rewrite

Revise regNJ function:

It now only uses the memory space of a single distance matrix, and overwrites new nodes into one of the merged nodes. This does change the ordering of merges in the algorithm (i.e. the pseudoroot may change) but the unrooted tree is confirmed to be the same (i.e. patristic distances don't change).

Update testing framework:

followed SciML organization with safetestsets and made each testset a regular script

Update Docs:

added doctests, and new docstrings for heights and merges functions

Add benchmark suite:

I am now testing on matrices up to size 1024, with the revision regNJ seems much faster than before, but some of that seems to be testing on yuletree matrices rather than uniformly random matrices

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/99737

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.0 -m "<description of version>" f3b937fab6d7474b9e7765a5ff4a56cdb1e716c3
git push origin v0.2.0

@BenjaminDoran
Copy link
Owner Author

@JuliaRegistrator register

Release notes:

Dev (v0.2) rewrite

Revise regNJ function:

It now only uses the memory space of a single distance matrix, and overwrites new nodes into one of the merged nodes. This does change the ordering of merges in the algorithm (i.e. the pseudoroot may change) but the unrooted tree is confirmed to be the same (i.e. patristic distances don't change).

Update testing framework:

followed SciML organization with safetestsets and made each testset a regular script

Update Docs:

added doctests, and new docstrings for heights and merges functions

Add benchmark suite:

I am now testing on matrices up to size 1024, with the revision regNJ seems much faster than before, but some of that seems to be testing on yuletree matrices rather than uniformly random matrices

@JuliaRegistrator
Copy link

Registration pull request updated: JuliaRegistries/General/99737

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.0 -m "<description of version>" f3b937fab6d7474b9e7765a5ff4a56cdb1e716c3
git push origin v0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants