Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QoS configuration to RosNodeParams #99

Open
wants to merge 3 commits into
base: humble
Choose a base branch
from

Conversation

rafal-gorecki
Copy link

@rafal-gorecki rafal-gorecki commented Oct 21, 2024

I really like this pkg and the way it was created. Bravo to the authors!

The only thing missing is the ability to set QoS for topics.
By the way, I also added the ability to change the qos_profile for services.

I found other solutions with similar themes, which may be updated if this PR passes:

@rafal-gorecki rafal-gorecki marked this pull request as draft October 21, 2024 16:32
@rafal-gorecki rafal-gorecki marked this pull request as ready for review October 21, 2024 16:45
@rafal-gorecki
Copy link
Author

Hello @tony-p @facontidavide,
Can I ask one of u guys for review?

@tony-p
Copy link
Contributor

tony-p commented Nov 14, 2024

I'm not a maintainer so can't push this further. My first thought was why not define the qos in the node implementation as it will typically be constant for a particular message type, but on reflection I think adding to the params probably does make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants