Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handling #36

Open
b-viguier opened this issue Oct 31, 2019 · 0 comments
Open

Exception handling #36

b-viguier opened this issue Oct 31, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b-viguier
Copy link
Contributor

Currently, any exception thrown by an adapter is propagated to upper context outside of Tornado. It means that if you intend to catch a particular exception, it may be broken as soon as you change the used adapter.

Proposal:

  • Catch underlying exceptions and translate them in "Tornado exceptions" (to be created)
  • Use @throws annotation to document this behavior and improve developer experience with IDE
@b-viguier b-viguier added enhancement New feature or request good first issue Good for newcomers labels Oct 31, 2019
@b-viguier b-viguier mentioned this issue Dec 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@b-viguier