-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow App reviewers to test unapproved and private apps #1402
base: main
Are you sure you want to change the base?
Conversation
use backend + dashboard, so that the admin could add themself as a tester. we should not add the Tester approval ability to the app for now. maybe later. remove the app changes pls sir 😌 |
I think you got it wrong haha This PR adds only the ability to enable and test apps for the testers. They can't approve/reject/review apps from within the omi app. Once the testers test the app, the admin or the tester can approve it from the dashboard Regarding the adding of testers, this only happens on the backend (currently hardcoded to only my uid), if we wish to store the testers UIDs somewhere in db, we can do that as well. Every call for testing from the front-end checks if the UID is authorised to perform the action |
i mean the ability to add/remove the tester. just don't put it in the mobile app for now. so there's no app changes. so let's go with this way: just like how the Testflight / Internal test works - a dead simple ver. what do you think man ?😌 |
I see, I understood how you want it to be. The way I built it, it was only supposed to be for Salman and Neo (and other team members) to be able to just test apps before reviewing them (hence the separate admin area). But what you said also is a nice approach where we can have many reviewers or let anyone be the reviewer. To your approach, what if we make slight changes such that the app creator can allow others as testers (similar to Android Internal Testing). The creator will simply enter the UIDs or the emails of the people whom he want to allow to test, and then simply those users will have access to that app while it is unapproved and private |
yes but not now bro. let's enable that feature later, maybe via app, maybe via web. for now, just put it in the admin dashboard. keep the app simple ;) |
Alright got it. Let me finish it |
Up for review with your suggested changes @beastoin |
let's improve it a bit @mdmohsin7 |
1/ I thought about this and I decided to place it at root because when we are dealing with triggers, we will have to iteratively fetch all the apps and then find the ones where the user is a tester. In current implementation, we will know already for what apps the user is a tester, so we eliminate the need for going through or filtering through all the apps to find the apps for which the tester has permission to test 2/ Got it! So I should replace |
1/ > we will have to iteratively fetch all the apps and then find the ones where the user is a tester 2/ don't make me says it twice, do some research, fix it, then ask me to review your new code. |
Pls check @beastoin |
Adds the ability for admins to add testers and give them access to specific apps to test (that are not yet approved)