Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Network class with network specific information #118

Open
btcookies opened this issue Nov 8, 2021 · 0 comments
Open

Create Network class with network specific information #118

btcookies opened this issue Nov 8, 2021 · 0 comments
Labels
good first issue Good for newcomers techdebt BAU code improvements / test coverage

Comments

@btcookies
Copy link
Contributor

btcookies commented Nov 8, 2021 •
edited
Loading

Enum refactor has led to cleaning up a lot of the code base, to further improve the architecture we should create a network class that contains basic information for each network. We can then store Network objects in a dict in constants.py and reference information from there.

  • network name
  • base currency
  • gas oracle
  • rpc (or list of rpcs)
  • explorer
@btcookies btcookies added good first issue Good for newcomers techdebt BAU code improvements / test coverage labels Nov 8, 2021
@btcookies btcookies mentioned this issue Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers techdebt BAU code improvements / test coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@btcookies