-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guardian
in governance-timelock
is redundant
#1294
Comments
guardian
in ops_multisig_old
is redundantguardian
in governance-timelock
is redundant
probably worthy to be batch whenever #1277 is posted |
I agree on changing the guardian to a live Multisig and it should be one with very little overlap with Dev, for instance TechOps. The reason for this is that the guardian should be able interfere vetoing malicious transactions in case that dev is compromised. I would defer to @GalloDaSballo and @dapp-whisperer for the best configuration though. |
@dapp-whisperer if we want to be super cautious guardian could be a List of EOAs No strong opinion until I understand the goal of the timelock |
the goal of the TL is to put the minting/burning actions of badger token behind that |
so without the guardian role being able to call
@GalloDaSballo how can the guardian be a list of eoas? only way that could work imo is by setting up a separate multisig owned by these eoas with a threshold of 1.. i would say techops is best option for now too, and agree to batch it with #1277 |
edit: |
Currently the
guardian
in governance-timelock is a deprecated msig, where the only owner isdevmsig
as of now.This configuration kind of defeats the purpose of guardian which has rights to cancel transaction that has being queued, while the admin and the guardian are exactly the same addr.
General consensus
It is to set the
techops
as the guardian for the time being, despite that stilldevmsig
atomically could remove theguardian
at pleasure. Something to consider that needs more check/balances to ensure that could not happen atomicallyConsiderations:
The text was updated successfully, but these errors were encountered: