Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mnc2dcm tools on develop not installed #57

Open
gdevenyi opened this issue Nov 2, 2016 · 3 comments
Open

mnc2dcm tools on develop not installed #57

gdevenyi opened this issue Nov 2, 2016 · 3 comments

Comments

@gdevenyi
Copy link

gdevenyi commented Nov 2, 2016

I thin a small tweak to cmake is needed to install these tools.

@andrewjanke
Copy link
Member

This is likely because they aren't complete. They 90% work but it was more an itch of mine that I scratched a while back rather than a complete converter. Am also not sure of the licencing on the DICOM perl module, I made some modifications to it to get this to work IIRC.

@gdevenyi
Copy link
Author

gdevenyi commented Nov 3, 2016

Okay. dcmsort is fantastic. I use it constantly.

@andrewjanke
Copy link
Member

I should add that I think the best way forward for this is to port both dcmsort and mnc2dcm to use dcmtk instead of DICOM.pm. That would be dcmdump for dcmsort and img2dcm for mnc2dcm.

dcmtk has long term support unlike the DICOM perl module I modified such that it would write DICOM in addition to reading it. The main issue was that the DICOM perl module doesn't create correct DICOM UID's IIRC. img2dcm does. The main issue would be to check that dcmsort will still run with acceptable speed.

If this is done then it would make sense to include it as part of minc-tools proper via cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants