-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev-env): migration from vipdev.lndo.site
to vipdev.site
#851
base: master
Are you sure you want to change the base?
Conversation
Trivy Scan Reportghcr.io/automattic/vip-container-images/dev-tools:0.9 (alpine 3.20.3)No vulnerabilities found. |
How do we make sure we don't break things for existing dev-env users who aren't running on the latest CLI? 😬 |
@rebeccahum Images are updated independently of VIP CLI. For the existing environments, images are re-pulled every two weeks. For new environments, they are pulled on the first start. The idea is to merge this PR and ship Automattic/vip-cli#1984, say, in a month. |
@sjinks Right, but then it means someone on the old version will download the new image and the migration routine will run for them? |
The migration routine will start if the new domain is |
@rebeccahum ideally we should test a bit :) |
@rinatkhaziev testing? don't know her |
Testing, please meet @rebeccahum. Rebecca, please meet Testing, our good friend. |
@rebeccahum @rinatkhaziev is it ok to merge this? Or are you still having fun with Testing? |
@sjinks Haven't reached out to Testing yet, are you able to? |
I actually did :-) (like a month ago) This is what we were doing:
|
I'm gonna try to break it, stay tuned. |
682c809
to
8b60798
Compare
This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved. |
No description provided.