feat: adds Web3SubscriptionsManager.get_subscription_data_nowait() #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Jul 12, 2024
mikeshultz
changed the title
fubuloubu
reviewed
Jul 14, 2024
fubuloubu
approved these changes
Jul 16, 2024
| if not self.connection: | ||
| raise ConnectionError("Connection not opened") | ||
|
|
||
| message = await asyncio.wait_for(self.connection.recv(), timeout) |
There was a problem hiding this comment.
Is this the location where node websockets end up raising after getting randomly dropped?
There was a problem hiding this comment.
Looks like it, according to the trace on #84
There was a problem hiding this comment.
Nice, we might want to come back later and handle this timeout by reconnecting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adds
Web3SubscriptionsManager.get_subscription_data_nowait()to add the ability to poll without a hanging iterator.Checklist