refactor: use quattro #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enables asyncio.run "Debug mode":
https://docs.python.org/3/library/asyncio-dev.html#asyncio-debug-mode
fubuloubu
force-pushed
the
refactor/use-quattro
branch
from
7d42589
to
2023c8e
Compare
|
Have to debug why shutdown tasks are not running with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Quattro has a Python 3.10+ compatible implementation of TaskGroups (which is 3.11+), and some other nicer API for working with some asyncio functions (such as gather) using TaskGroups where we should get more stable error messages on internal failures (i.e. no leakage of internal tasks failing)
Will attempt to fix #67 if we can
fixes SBK-428
How I did it
How to verify it
Checklist