-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylint alerts corrections as part of an intervention experiment #306
Comments
Hi @evidencebp, lets try it. |
I created a PR withthe changes. Currently all of them are too long lines so rather minor. |
@AndreiDrang , I would like to consult you regarding the broad-exception-caught alert in src\python_rucaptcha\core\result_handler.py Too braod exception might lead to problem if the developer planed to catch a specific exception and the exception also catchs and hides different exceptions. Both get_sync_result (in line 34) and get_async_result (in line 63) catch Exception. |
@AndreiDrang , I got an alert that the tests fail. I noted that the description is usually: My PR made long lines shorter. |
Hi |
Thanks, @AndreiDrang! |
Is your feature request related to a problem? Please describe.
The feature is not related to a problem but to code readability.
Describe the solution you'd like
I'd like to conduct a software engineering experiment regarding the benefit of Pylint alerts removal.
The experiment is described here.
In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control.
After the interventions are done, one can wait and examine the results.
I'm asking for your approval for conducting an intervention in your repository.
See examples of interventions in stanford-oval/storm, gabfl/vault, and coreruleset/coreruleset.
You can see the planed interventions
May I do the interventions, @AndreiDrang ?
Describe alternatives you've considered
There is a single broad-exception-caught alert and the rest are too long lines.
This is not critical so an alternative will be to leave it as is.
However, the PR will be easy and there will be beneit in it.
Additional context
The text was updated successfully, but these errors were encountered: